您的位置: 首页  >  技术问答  >  我是否必须重新开始？

我是否必须重新开始？

分类: 技术问答 • 2022-07-24 14:04:31
问题描述：

请把它给我简单而简单。我试图用一个哨兵节点来实现一个循环双向链表，并且提出了一些更高或更低的游戏，它们往返前进，并循环播放。它工作正常....除了我意识到我必须有两个单独的文件的环模块（一个.h和一个.c），然后单独的主文件。代码很长，在我意识到我的错误之后，我没有整理它，因为它是毫无意义的。所以即时通讯不要求你阅读它或检查错误或任何东西。但是如果你能以1-10的分数告诉我这种情况有多糟糕，那么我会非常感激。只是这样我就可以让我的头周围的什么IM将不得不做...谢谢我是否必须重新开始？

#include <stdio.h> 
#include <stdlib.h> 
#include <string.h> 
#include <ctype.h> 
#include <time.h> 
#define PLAYERLIMIT 5 

//Doubly linked list implementation 
struct Node { 
    char data[20]; 
    struct Node* next; 
    struct Node* prev; 
}; 
struct Node* sentinel; //global pointer to the sentinel node 
struct Node* head; 
struct Node* tail; 

// Create sentinel node, originally it just points to itself 

struct Node* MakeSentinel() { 
struct Node* SentinelNode = 
(struct Node*)malloc(sizeof(struct Node)); 
SentinelNode->next = SentinelNode->next; 
SentinelNode->prev = SentinelNode->prev; 
return SentinelNode; 
} 

//Creation of a node takes an int and returns a node 
struct Node* GetNewNode (char *x) { 
    struct Node* newNode = 
    (struct Node*)malloc(sizeof(struct Node)); //created node in the dynamic memory 
strcpy (newNode->data, x); //temp->data is same as (*temp).data 
newNode->prev = NULL; 
newNode->next = NULL; 
return newNode; 
} 

//Returning a pointer to newly created node, inserts next to sentinel 
void InsertAtHead (char *x){ 
    struct Node* newNode = GetNewNode(x); 
if (sentinel == NULL) { 
    sentinel = MakeSentinel(); 
    head = newNode; 
    sentinel->next = head; 
    sentinel->prev = head; 
    head->next = sentinel; 
    head->prev = sentinel; 
    return; 
} 
head->prev = newNode; 
newNode->next = head; 
newNode->prev = sentinel; 
sentinel->prev = newNode; 
head = newNode; 
} 

void PrintHead() { 
// printf("Sentinel prev is %s\n", sentinel->prev->data); 
struct Node* temp = sentinel->prev; 
printf("~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n"); 
printf("The players in the game are\n\n"); 
while (temp != sentinel) { 
    printf ("%s ", temp->data); 
    temp = temp->next; 

} 
printf("\n"); 
printf("~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n"); 
} 

//Removing a name from the linked list 
void DeleteEntry (struct Node* del) { 
    if ((del->next != sentinel) && (del->prev != sentinel)) { 
del->next->prev = del->prev; 
del->prev->next = del->next; 
} 
else if (del->next == sentinel) { 
    del->next->next = del->prev; 
    del->prev->next = del->next; 
} 
else if(del->prev == sentinel) { 
    del->next->prev = del->prev; 
    del->prev->prev = del->next; 
} 
// printf("Sentinel prev is now%s\n", sentinel->prev->data); 

return; 
} 



int main(int argc, char *argv[]) { 

//Entering all player names into the doubly linked list 
printf ("Enter the names of the players. Press Enter after each new player\n"); 
printf ("Must have 5 Players'.'\n\n"); 

int i = 1; 
char name[20]; 


while ((i <= PLAYERLIMIT)) { 

    printf("Player: "); 
    scanf ("%s", name); 
    InsertAtHead(name); 
    i++; 

} 
PrintHead(); 

//Starting the Game 

//Initialising Variables for the game 
int nextCard; 
int currentCard; 
int score; 
char oppositeGuess[20]; 
int userChoice; 
int playGame = 1; 
struct Node* CurrentPlayer = head; 
struct Node* PlayerBefore; 

//Setting up the random cards 
int range; 
srand(time(NULL)); 
range = (13 - 1) + 1; 

nextCard = rand() % range + 2; 
currentCard = rand() % range + 2; 

while (playGame == 1) { 

    //Change current card to past card before creating a new current card 
    currentCard = nextCard; 

    //generate a random int for card 

    nextCard = rand() % range + 2; 

    if (currentCard < 11) { 
     printf("\nThe current card is a %d.\n", currentCard); 
    } 
    else if (currentCard == 11) { 
     printf("\nThe current card is a jack.\n"); 
    } 
    else if (currentCard == 12) { 
     printf("\nThe current card is a queen.\n"); 
    } 
    else if (currentCard == 13) { 
     printf("\nThe current card is a king.\n"); 
    } 
    else if (currentCard == 14) { 
     printf("\nThe current card is an ace.\n"); 
    } 

    printf ("***%s it is your go!***\n", CurrentPlayer->data); 
    if (CurrentPlayer->prev != sentinel) { 
     PlayerBefore = CurrentPlayer->prev; 

    } 
    else { 
     PlayerBefore = sentinel->next; 

    } 
//  printf("\nThe CurrentPlayer is %s\n", CurrentPlayer->data); 
//  printf("The PlayerBefore is %s\n\n", PlayerBefore->data); 
    printf("Will the next card be higher(1) or lower(2)?\n"); 
    scanf("%d", &userChoice); 
    printf("\n"); 
    printf ("***%s would you like to guess the opposite?***\n", PlayerBefore->data); 
    scanf("%s", oppositeGuess); 
    if (strncmp(oppositeGuess, "Yes", 4) == 0) { 

     if (userChoice == 1) { 
      if (currentCard < nextCard) { 
       printf("\nSorry, %s was correct. You are out!\n", CurrentPlayer->data); 
//     printf ("\n IM GONNA DELETE %s\n", PlayerBefore->data); 
       DeleteEntry(PlayerBefore); 

      } 
      else if (currentCard > nextCard) { 
       printf ("Congratulations! player %s was wrong and is now out!\n", CurrentPlayer->data); 
//     printf ("\n IM GONNA DELETE %s\n", CurrentPlayer->data); 
       DeleteEntry(CurrentPlayer); 

      } 
      else if (currentCard == nextCard){ 
       printf("\nCards were equal. Next players turn.\n"); 
      } 
     } 
     else if (userChoice == 2) { 
      if (currentCard < nextCard) { 
       printf("Congratulations! player %s was wrong and is now out!\n", CurrentPlayer->data); 
//     printf ("\n IM GONNA DELETE %s\n", CurrentPlayer->data); 
       DeleteEntry(CurrentPlayer); 

      } 
      else if (currentCard > nextCard) { 
       printf ("\nSorry, %s was correct. You are out!\n", CurrentPlayer->data); 
//     printf ("\n IM GONNA DELETE %s\n", PlayerBefore->data); 
       DeleteEntry(PlayerBefore); 

      } 
      else if (currentCard == nextCard){ 
       printf("\nCards were equal. Next players turn.\n"); 
      } 
     } 
    } 
    if (strncmp(oppositeGuess, "No", 4) == 0) { 

     if (userChoice == 1) { 
      if (currentCard > nextCard) { 
       printf ("\nSorry you have guessed incorrectly, you are out!\n"); 
//     printf ("\n IM GONNA DELETE %s\n", CurrentPlayer->data); 
       DeleteEntry(CurrentPlayer); 

      } 

      else if (currentCard < nextCard) { 
       printf("\nCongratualtions you were correct, next players turn.\n"); 
      } 
      else if (currentCard == nextCard) { 
       printf("\nThe cards are the same. Next players turn.\n"); 
      } 
     } 
     else if (userChoice == 2) { 
      if (currentCard > nextCard) { 
       printf ("\nCongratualtions you were correct, next players turn.\n"); 

      } 
      else if (currentCard < nextCard) { 
       printf("\nSorry you have guessed incorrectly, you are out!\n"); 
//     printf ("\n IM GONNA DELETE %s\n", CurrentPlayer->data); 
       DeleteEntry(CurrentPlayer); 


      } 
      else if (currentCard == nextCard) { 
       printf("\nThe cards are the same. Next players turn.\n"); 
      } 
     } 
     else { 
      printf("\nPlease enter a valid choice.\n"); 
     } 
    } 

     PrintHead(); 
    if (CurrentPlayer->next != sentinel) { 
     CurrentPlayer = CurrentPlayer->next; 
    } 
    else { 
     CurrentPlayer = sentinel->prev; 
    } 

    if ((CurrentPlayer->next == sentinel) && (CurrentPlayer->prev == sentinel)) { 
     playGame = 0; 
    } 
} 
printf("%s you are the Winner!\n", CurrentPlayer->data); 
}
+0

我不认为你需要重新开始：你可以使用这个机会来重构和测试你的代码。 –

答

在1-10分，我认为这个代码是值得保存的规模：你已经采取了相当单调乏味的练习（制作一张圆形列表）并将其变成有趣的东西。

对于为不同模块分开文件没有问题，可以使用#include命令包含它们。例如，如果你把所有的链接列表的东西，在mydllist.c

//Doubly linked list implementation 
struct Node { 
    char data[20]; 
    struct Node* next; 
    struct Node* prev; 
}; 

struct Node* sentinel; //global pointer to the sentinel node 
struct Node* head; 
struct Node* tail; 

// Create sentinel node, originally it just points to itself 

struct Node* MakeSentinel() { 
    struct Node* SentinelNode = (struct Node*)malloc(sizeof(struct Node)); 
    SentinelNode->next = SentinelNode->next; 
    SentinelNode->prev = SentinelNode->prev; 
    return SentinelNode; 
} 

//Creation of a node takes an int and returns a node 
struct Node* GetNewNode (char *x) { 
    struct Node* newNode = (struct Node*)malloc(sizeof(struct Node)); //created node in the dynamic memory 
    strcpy (newNode->data, x); //temp->data is same as (*temp).data 
    newNode->prev = NULL; 
    newNode->next = NULL; 
    return newNode; 
} 

//Returning a pointer to newly created node, inserts next to sentinel 
void InsertAtHead (char *x){ 
    struct Node* newNode = GetNewNode(x); 
    if (sentinel == NULL) { 
     sentinel = MakeSentinel(); 
     head = newNode; 
     sentinel->next = head; 
     sentinel->prev = head; 
     head->next = sentinel; 
     head->prev = sentinel; 
     return; 
    } 

head->prev = newNode; 
newNode->next = head; 
newNode->prev = sentinel; 
sentinel->prev = newNode; 
head = newNode; 
} 

void PrintHead() { 
// printf("Sentinel prev is %s\n", sentinel->prev->data); 
    struct Node* temp = sentinel->prev; 
    printf("~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n"); 
    printf("The players in the game are\n\n"); 
    while (temp != sentinel) { 
    printf ("%s ", temp->data); 
    temp = temp->next; 

    } 
    printf("\n"); 
    printf("~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n"); 
} 

//Removing a name from the linked list 
void DeleteEntry (struct Node* del) { 
    if ((del->next != sentinel) && (del->prev != sentinel)) { 
     del->next->prev = del->prev; 
     del->prev->next = del->next; 
    } 
    else if (del->next == sentinel) { 
     del->next->next = del->prev; 
     del->prev->next = del->next; 
    } 
    else if(del->prev == sentinel) { 
     del->next->prev = del->prev; 
     del->prev->prev = del->next; 
    } 
    // printf("Sentinel prev is now%s\n", sentinel->prev->data); 

    return; 
}

可以将其包含在dllist_game.c文件中像这样的顶部：

#include <stdio.h> 
#include <stdlib.h> 
#include <string.h> 
#include <ctype.h> 
#include <time.h> 
#include "mydllist.c"

我然后做一些启动简单的重构，特别是main（）函数的重构，使代码更易于理解。

随着你#define PLAYERLIMIT 5我想添加一个#define NUMBER_OF_CARDS 13（或其他卡的最大数量为）与枚举类型布尔值

typedef enum {true, false} bool;

这样一起当你定义的范围，而不是写的：

int range; 
srand(time(NULL)); 
range = (13 - 1) + 1 //n.b. (13 - 1) + 1 = 13 is there some reason you wrote it like this?

你可以写

int range = NUMBER_OF_CARDS; 
srand(time(NULL));

它总是一个好主意来初始化变量的默认值：你可能会忘记他们是未初始化，并尝试使用它们（这有可能是坏的）：

int nextCard = 0; 
int currentCard = 0; 
int score = 0; 
char oppositeGuess[20] = ""; 
int userChoice = 0 ; 
bool playGame = true; 
struct Node* CurrentPlayer = head; 
struct Node* PreviousPlayer = head->prev;

我会改变环路的名称计数器从i到num_entered_players，所以它更容易看到的变量是什么时，它的使用：

int num_entered_players = 1; 
char name[20]; 

while ((entered_players <= PLAYERLIMIT)) { 
    printf("Player: "); 
    scanf ("%s", name); 
    InsertAtHead(name); 
    num_entered_players++; 
}

最后，我会开始提取大while环路的部分成更小的功能，这说明这是怎么回事。例如，行：

if (currentCard < 11) { 
    printf("\nThe current card is a %d.\n", currentCard); 
} 
else if (currentCard == 11) { 
    printf("\nThe current card is a jack.\n"); 
} 
else if (currentCard == 12) { 
    printf("\nThe current card is a queen.\n"); 
} 
else if (currentCard == 13) { 
    printf("\nThe current card is a king.\n"); 
} 
else if (currentCard == 14) { 
    printf("\nThe current card is an ace.\n"); 
}

将成为：

void printCurrentCard(int currentCard){ 

    if (currentCard < 11) { 
     printf("\nThe current card is a %d.\n", currentCard); 
    } 
    else if (currentCard == 11) { 
     printf("\nThe current card is a jack.\n"); 
    } 
    else if (currentCard == 12) { 
     printf("\nThe current card is a queen.\n"); 
    } 
    else if (currentCard == 13) { 
     printf("\nThe current card is a king.\n"); 
    } 
    else if (currentCard == 14) { 
     printf("\nThe current card is an ace.\n"); 
    } 
}

，并会被称为是这样的：

while (playGame == true) { 

    //Change current card to past card before creating a new current card 
    currentCard = nextCard; 

    //generate a random int for card 
    nextCard = rand() % range + 2; 

    printCurrentCard(currentCard); 

.... 
}

等，所以如果你改变在一个特定的游戏规则一步，只有一个地方需要更改代码 - 而且不应该影响游戏的其余部分。

一旦你完成了这些改变 - 你的游戏的逻辑可以进入另一对.c和.h文件，你可以直接从一个单独的main（）中调用它！

相关推荐